Merge pull request 'Implement Call Recording for STT and Replay' (#3) from implement-call-recording into main

Reviewed-on: #3

.env.example

@@ -1,5 +1,9 @@
 NODE_ID=
 MQTT_BROKER=
 ICECAST_SERVER=
+AUDIO_BUCKET=
 NODE_LAT=
 NODE_LONG=
+HTTP_SERVER_PROTOCOL=
+HTTP_SERVER_ADDRESS=
+HTTP_SERVER_PORT=

.gitignore

@@ -3,3 +3,4 @@
 *.db
 *.conf
 configs/*
+*.json

Dockerfile

@@ -7,7 +7,7 @@ ENV DEBIAN_FRONTEND=noninteractive
 # Install system dependencies
 RUN apt-get update && \
     apt-get upgrade -y && \ 
-    apt-get install git pulseaudio pulseaudio-utils liquidsoap -y
+    apt-get install git pulseaudio pulseaudio-utils liquidsoap ffmpeg -y
 
 # Clone the boatbod op25 repository
 RUN git clone -b gr310 https://github.com/boatbod/op25 /op25
@@ -34,6 +34,9 @@ EXPOSE 8001 8081
 # Create and set up the configuration directory
 VOLUME ["/configs"]
 
+# Create the calls local cache directory
+VOLUME ["/calls"]
+
 # Set the working directory in the container
 WORKDIR /app
 

app/internal/op25_config_utls.py

@@ -3,9 +3,10 @@ import json
 import os
 import shutil
 from pathlib import Path
-from models.models import TalkgroupTag
+from models.models import TalkgroupTag, IcecastConfig
 from typing import List, Dict
 from internal.logger import create_logger
+from internal.liquidsoap_config_utils import generate_liquid_script
 
 LOGGER = create_logger(__name__)
 
@@ -66,6 +67,27 @@ def activate_config_from_library(system_name: str) -> bool:
         if src_whitelist.exists():
             shutil.copy2(src_whitelist, config_path / "active.cfg.whitelist.tsv")
 
+        # Generate Liquidsoap Script by reading the activated config
+        with open(dst, 'r') as f:
+            data = json.load(f)
+
+        if "trunking" in data and "metadata" in data:
+            streams = data.get("metadata", {}).get("streams", [])
+            if streams:
+                stream = streams[0]
+                address = stream.get("icecastServerAddress", "127.0.0.1:8000")
+                host, port = address.split(":") if ":" in address else (address, 8000)
+                
+                ice_config = IcecastConfig(
+                    icecast_host=host,
+                    icecast_port=int(port),
+                    icecast_mountpoint=stream.get("icecastMountpoint", "/stream"),
+                    icecast_password=stream.get("icecastPass", "hackme"),
+                    icecast_description="OP25 Stream",
+                    icecast_genre="Scanner"
+                )
+                generate_liquid_script(ice_config)
+
         return True
     except Exception as e:
         LOGGER.error(f"Failed to copy config: {e}")

app/node_main.py

@@ -20,6 +20,9 @@ app.include_router(create_op25_router(), prefix="/op25")
 # Configuration
 NODE_ID = os.getenv("NODE_ID", "standalone-node")
 MQTT_BROKER = os.getenv("MQTT_BROKER", None)
+HTTP_SERVER_PROTOCOL = os.getenv("HTTP_SERVER_PROTOCOL", "http")
+HTTP_SERVER_ADDRESS = os.getenv("HTTP_SERVER_ADDRESS", "127.0.0.1")
+HTTP_SERVER_PORT = os.getenv("HTTP_SERVER_PORT", 8000)
 NODE_LAT = os.getenv("NODE_LAT")
 NODE_LONG = os.getenv("NODE_LONG")
 
@@ -112,6 +115,37 @@ def handle_c2_command(topic, payload):
     except Exception as e:
         LOGGER.error(f"Error processing C2 command: {e}")
 
+def get_current_stream_url():
+    """
+    Dynamically resolves the audio stream URL from the active OP25 configuration.
+    Falls back to env var or default if config is missing/invalid.
+    """
+    default_url = os.getenv("STREAM_URL", "http://127.0.0.1:8000/stream_0")
+    config_path = "/configs/active.cfg.json"
+    
+    if not os.path.exists(config_path):
+        return default_url
+        
+    try:
+        with open(config_path, "r") as f:
+            config = json.load(f)
+        
+        streams = config.get("metadata", {}).get("streams", [])
+        if not streams:
+            return default_url
+            
+        stream = streams[0]
+        address = stream.get("icecastServerAddress", "127.0.0.1:8000")
+        mount = stream.get("icecastMountpoint", "stream_0")
+        
+        if not mount.startswith("/"):
+            mount = f"/{mount}"
+            
+        return f"http://{address}{mount}"
+    except Exception as e:
+        LOGGER.warning(f"Failed to resolve stream URL from config: {e}")
+        return default_url
+
 async def mqtt_lifecycle_manager():
     """
     Manages the application-level logic: Check-in, Heartbeats, and Shutdown.
@@ -153,7 +187,7 @@ async def mqtt_lifecycle_manager():
         payload = {
             "node_id": NODE_ID,
             "status": "online",
-            "timestamp": datetime.now().isoformat(),
+            "timestamp": datetime.utcnow().isoformat(),
             "is_listening": op25_status.get("is_running", False),
             "active_system": op25_status.get("active_system"),
             # Only scan library if needed, otherwise it's heavy I/O
@@ -186,12 +220,49 @@ async def mqtt_lifecycle_manager():
     async def metadata_watcher():
         """
         Polls OP25 HTTP terminal for metadata and publishes events to MQTT.
+        Corrected to use the POST-based command API found in the HAR capture.
         """
         last_tgid = 0
         last_metadata = {}
         potential_end_time = None
         DEBOUNCE_SECONDS = 2.5
-        OP25_DATA_URL = "http://127.0.0.1:8081/data.json"
+        OP25_DATA_URL = "http://127.0.0.1:8081/"
+        
+        # This is the specific payload the OP25 web interface uses [cite: 45562, 45563]
+        COMMAND_PAYLOAD = [{"command": "update", "arg1": 0, "arg2": 0}]
+
+        # Audio Recording State
+        recorder_proc = None
+        current_call_id = None
+
+        async def stop_recording():
+            nonlocal recorder_proc
+            if recorder_proc:
+                if recorder_proc.returncode is None:
+                    recorder_proc.terminate()
+                    try:
+                        await asyncio.wait_for(recorder_proc.wait(), timeout=2.0)
+                    except asyncio.TimeoutError:
+                        recorder_proc.kill()
+                recorder_proc = None
+
+        def upload_audio(call_id):
+            if not MQTT_BROKER: return None
+            local_path = f"/calls/{call_id}.mp3"
+            if not os.path.exists(local_path): return None
+            
+            try:
+                with open(local_path, "rb") as f:
+                    files = {"file": (f"{call_id}.mp3", f, "audio/mpeg")}
+                    response = requests.post(f"{HTTP_SERVER_PROTOCOL}://{HTTP_SERVER_ADDRESS}:{HTTP_SERVER_PORT}/upload", files=files, data={"node_id": NODE_ID, "call_id": call_id}, timeout=30)
+                    response.raise_for_status()
+                    return response.json().get("url")
+            except Exception as e:
+                LOGGER.error(f"Upload failed: {e}")
+                return None
+            finally:
+                if os.path.exists(local_path):
+                    os.remove(local_path)
 
         while True:
             if not MQTT_CONNECTED:
@@ -199,69 +270,130 @@ async def mqtt_lifecycle_manager():
                 continue
 
             try:
-                # Run blocking request in executor to avoid blocking the asyncio loop
+                # Run blocking POST request in executor 
                 loop = asyncio.get_running_loop()
-                response = await loop.run_in_executor(None, lambda: requests.get(OP25_DATA_URL, timeout=0.5))
+                response = await loop.run_in_executor(
+                    None, 
+                    lambda: requests.post(OP25_DATA_URL, json=COMMAND_PAYLOAD, timeout=0.5)
+                )
                 
                 if response.status_code == 200:
                     data = response.json()
+                    # LOGGER.debug(f"Response from OP25 API: {data}")
                     
                     current_tgid = 0
                     current_meta = {}
 
-                    # Handle multi_rx list or single dict structure
-                    if isinstance(data, list):
-                        for ch in data:
-                            t = ch.get("tgid", 0)
-                            if t and int(t) > 0:
-                                current_tgid = int(t)
-                                current_meta = {
-                                    "tgid": str(t),
-                                    "alpha_tag": str(ch.get("tag", "")).strip(),
-                                    "frequency": str(ch.get("freq", 0)),
-                                    "sysname": str(ch.get("system", "")).strip()
-                                }
-                                break
-                    elif isinstance(data, dict):
-                        t = data.get("tgid", 0)
-                        if t and int(t) > 0:
-                            current_tgid = int(t)
-                            current_meta = {
-                                "tgid": str(t),
-                                "alpha_tag": str(data.get("tag", "")).strip(),
-                                "frequency": str(data.get("freq", 0)),
-                                "sysname": str(data.get("system", "")).strip()
-                            }
+                    # The response is an array of update objects 
+                    for item in data:
+                        if item.get("json_type") == "channel_update":
+                            # The terminal provides channel info keyed by channel index (e.g., "0") 
+                            # We look for the first channel that has an active TGID
+                            for key in item:
+                                if key.isdigit():
+                                    ch = item[key]
+                                    t = ch.get("tgid")
                                     
-                    now = datetime.now()
+                                    # OP25 returns null or 0 when no talkgroup is active 
+                                    if t and int(t) > 0:
+                                        current_tgid = int(t)
+                                        current_meta = {
+                                            "tgid": str(t),
+                                            "rid": str(ch.get("srcaddr", "")).strip(),
+                                            "alpha_tag": str(ch.get("tag", "")).strip(),
+                                            "frequency": str(ch.get("freq", 0)),
+                                            "sysname": str(ch.get("system", "")).strip()
+                                        }
+                                        break
+                            if current_tgid: break
 
+                    now = datetime.utcnow()
+
+                    # Logic for handling call start/end events
                     if current_tgid != 0:
-                        potential_end_time = None # Reset debounce
+                        potential_end_time = None 
                         
                         if current_tgid != last_tgid:
                             if last_tgid != 0:
-                                # End previous call immediately if switching channels
-                                payload = {"node_id": NODE_ID, "timestamp": now.isoformat(), "event": "call_end", "metadata": last_metadata}
+                                # --- END PREVIOUS CALL ---
+                                await stop_recording()
+                                audio_url = None
+                                if current_call_id:
+                                    audio_url = await loop.run_in_executor(None, upload_audio, current_call_id)
+
+                                LOGGER.debug(f"Switching TGID: {last_tgid} -> {current_tgid}")
+                                payload = {
+                                    "node_id": NODE_ID, 
+                                    "timestamp": now.isoformat(), 
+                                    "event": "call_end", 
+                                    "metadata": last_metadata,
+                                    "audio_url": audio_url,
+                                    "call_id": current_call_id
+                                }
                                 client.publish(f"nodes/{NODE_ID}/metadata", json.dumps(payload), qos=0)
                             
-                            # Start new call
-                            payload = {"node_id": NODE_ID, "timestamp": now.isoformat(), "event": "call_start", "metadata": current_meta}
+                            # --- START NEW CALL ---
+                            LOGGER.debug(f"Call Start: TGID {current_tgid} ({current_meta.get('alpha_tag')})")
+                            
+                            # Generate ID
+                            start_ts = int(now.timestamp())
+                            sysname = current_meta.get('sysname', 'unknown')
+                            tgid = current_meta.get('tgid', '0')
+                            current_call_id = f"{NODE_ID}_{sysname}_{tgid}_{start_ts}"
+
+                            # Start Recording (FFmpeg)
+                            try:
+                                stream_url = get_current_stream_url()
+                                recorder_proc = await asyncio.create_subprocess_exec(
+                                    "ffmpeg", "-i", stream_url, "-y", "-t", "300", 
+                                    f"/calls/{current_call_id}.mp3",
+                                    stdout=asyncio.subprocess.DEVNULL,
+                                    stderr=asyncio.subprocess.DEVNULL
+                                )
+                            except Exception as e:
+                                LOGGER.error(f"Failed to start recorder: {e}")
+
+                            payload = {
+                                "node_id": NODE_ID, 
+                                "timestamp": now.isoformat(), 
+                                "event": "call_start", 
+                                "metadata": current_meta,
+                                "call_id": current_call_id
+                            }
                             client.publish(f"nodes/{NODE_ID}/metadata", json.dumps(payload), qos=0)
                             last_tgid = current_tgid
                             last_metadata = current_meta
                     
                     elif last_tgid != 0:
                         if potential_end_time is None:
+                            LOGGER.debug(f"Signal lost for TGID {last_tgid}. Starting debounce.")
                             potential_end_time = now
                         elif (now - potential_end_time).total_seconds() > DEBOUNCE_SECONDS:
-                            payload = {"node_id": NODE_ID, "timestamp": now.isoformat(), "event": "call_end", "metadata": last_metadata}
+                            # --- END CALL (Debounce Expired) ---
+                            await stop_recording()
+                            audio_url = None
+                            if current_call_id:
+                                audio_url = await loop.run_in_executor(None, upload_audio, current_call_id)
+
+                            LOGGER.debug(f"Call End (Debounce expired): TGID {last_tgid}")
+                            payload = {
+                                "node_id": NODE_ID, 
+                                "timestamp": now.isoformat(), 
+                                "event": "call_end", 
+                                "metadata": last_metadata,
+                                "audio_url": audio_url,
+                                "call_id": current_call_id
+                            }
                             client.publish(f"nodes/{NODE_ID}/metadata", json.dumps(payload), qos=0)
                             last_tgid = 0
                             last_metadata = {}
                             potential_end_time = None
+                            current_call_id = None
+                else:
+                    LOGGER.debug(f"OP25 API returned status: {response.status_code}")
 
-            except Exception:
-                pass # OP25 might be restarting or busy
+            except Exception as e:
+                LOGGER.warning(f"Metadata watcher error: {e}")
             
             await asyncio.sleep(0.25)
 

docker-compose.yml

@@ -7,6 +7,7 @@ services:
     restart: unless-stopped
     ports:
       - 8001:8001
+      - 8081:8081
     devices:
       - "/dev/bus/usb:/dev/bus/usb"
     volumes:
@@ -20,6 +21,10 @@ services:
       - NODE_LONG=${NODE_LONG}
       - MQTT_BROKER=${MQTT_BROKER}
       - ICECAST_SERVER=${ICECAST_SERVER}
+      - AUDIO_BUCKET=${AUDIO_BUCKET}
+      - HTTP_SERVER_PROTOCOL=${HTTP_SERVER_PROTOCOL}
+      - HTTP_SERVER_ADDRESS=${HTTP_SERVER_ADDRESS}
+      - HTTP_SERVER_PORT=${HTTP_SERVER_PORT}
     networks:
       - radio-shared-net