logan/node-26
1
0
Fork 0
Code Issues 14 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

A failed upload permanently deletes the recording: no retry, no disk spool #44

New Issue
Closed
opened 2026-10-27 19:57:41 -04:00 by logan · 1 comment
logan commented 2026-10-27 19:57:41 -04:00
Owner
Copy Link
Copy Source

call_recorder.upload_recording (drb-edge-node/app/internal/call_recorder.py, ~L787-808) makes one POST with httpx. On any exception it logs and returns None, and the finally block then calls file_path.unlink(). So a C2 outage, network blip, 5xx or timeout loses that call's audio for good.

The only offline buffer is the in-memory deque of call_end MQTT events (mqtt_manager.py, size 35), and that is lost on restart. The audio itself is never kept.

This is the recording foundation: a lost file is a lost call, transcript and incident link.

Fix shape: unlink only after a 2xx. Otherwise move the file to a bounded on-disk spool (size and age caps), retry with backoff, and drain the spool on startup. Treat 4xx (bad key) differently from 5xx/network errors. Needs drb-audio-review.

Found during the 2026-10-27 architecture review.

`call_recorder.upload_recording` (drb-edge-node/app/internal/call_recorder.py, ~L787-808) makes one POST with httpx. On any exception it logs and returns None, and the `finally` block then calls `file_path.unlink()`. So a C2 outage, network blip, 5xx or timeout loses that call's audio for good. The only offline buffer is the in-memory deque of call_end MQTT events (mqtt_manager.py, size 35), and that is lost on restart. The audio itself is never kept. This is the recording foundation: a lost file is a lost call, transcript and incident link. Fix shape: unlink only after a 2xx. Otherwise move the file to a bounded on-disk spool (size and age caps), retry with backoff, and drain the spool on startup. Treat 4xx (bad key) differently from 5xx/network errors. Needs drb-audio-review. Found during the 2026-10-27 architecture review.
logan added the
type
bug
area/recording-audio
priority
p1
kind
behavior-bug
 labels 2026-10-27 19:57:41 -04:00
logan commented 2026-11-01 06:39:51 -05:00
Author
Owner
Copy Link
Copy Source

Fixed in 6b884d5 + b62912b + 5983ae2, merged to main as c57a5b9 (PR #47). Server-side companions #301/#302 are on server branch feat/ai-pipeline-review, not merged yet.

Fixed in 6b884d5 + b62912b + 5983ae2, merged to main as c57a5b9 (PR #47). Server-side companions #301/#302 are on server branch feat/ai-pipeline-review, not merged yet.
logan removed the
priority
p1
 label 2026-11-01 06:39:51 -05:00
logan closed this issue 2026-11-01 06:39:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/ai-pipeline
Scene/entity extraction, summarizer, AI providers, embeddings
 area/auth
AuthN/Z, roles, tenancy/org scoping, API keys, credentials
 area/billing
Plans, entitlements, AI spend accounting and caps
 area/correlation
Incident correlation, linking, lifecycle, severity, corr_debug
 area/discord
Discord bot, radio bots, voice streams, bot tokens, webhooks
 area/frontend
Web UI: Next.js app and the edge-node local dashboard
 area/governance
Board process, minutes, unattended runner, agent tooling
 area/growth
Go-to-market, outreach, cold email, discovery conversations
 area/infra-deploy
CI/CD, VM, registry, Firestore rules/indexes deploy, Terraform/Caddy
 area/legal
ToS, retention, licences/DAAs, CAN-SPAM, E&O, name suppression
 area/map
Live map: pins, paths, tiles, legend, geocoding
 area/mqtt
Node-C2 MQTT, checkins, commands, node sweeper, dynsec
 area/node-ota
Node install, enrollment, OTA updater, image skew
 area/osint
External feeds: cameras, 511, ADS-B, AIS, outages, and their licences
 area/recording-audio
Call capture, boundaries, PulseAudio, ring buffer, trimming, attribution
 area/sdr-radio
OP25 decode, SDR hardware/tuning, conventional, second SDR, mesh radio
 area/transcription
STT, transcript correction, place verification, name accuracy
 board
Board process: minutes and board-filed items
 board:agenda
Needs board scoping at the next sitting; CEO removes the label once scoped
kind
behavior-bug
Wrong product behavior; the instrument reads it correctly
kind
measurement-bug
Corrupts the recording/instrument (debug data, evals, health checks), not behavior
priority
p0
Drop everything: prod broken, live exposure, or owner-ruled P0
priority
p1
Next up: blocks a gate, a customer, or core incident quality
priority
p2
Normal: real defect or planned work, schedule in turn
priority
p3
Low: minor, cosmetic, or someday
status
blocked
Waiting on an external party, spend, or another issue
status
in-progress
Branch or PR open against it
status
needs-decision
Waiting on an owner or board ruling before work
status
needs-info
Root cause or repro unknown; needs a reading first
type
bug
Something built is wrong: code, data, or a measurement
type
chore
Maintenance, refactor, tests, pinning, cleanup: no user-visible change
type
decision
A ruling to make or record: board minutes, owner calls, legal reviews
type
docs
Docs, runbooks, CLAUDE.md, skills, SOPs
type
feature
New capability or an extension of an existing one
type
security
Security, privacy, credential or tenant-isolation exposure
type
tracking
Tracker, checklist, initiative or punch-list spanning several changes
No labels area/recording-audio
kind
behavior-bug
type
bug
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
logan
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: logan/node-26#44