Merge pull request 'Discord: per-bot OAuth "Connect a Discord server" backend (#225 S6)' (#260) from feat/225-s6-oauth-link into main

drb-c2-core/app/routers/discord.py

@@ -17,7 +17,6 @@ Auth:
 from __future__ import annotations
 
 import secrets
-from datetime import datetime, timezone
 from typing import Optional
 
 from fastapi import APIRouter, Depends, HTTPException, Path, Security
@@ -26,6 +25,7 @@ from fastapi.security import HTTPAuthorizationCredentials, HTTPBearer
 from pydantic import BaseModel, Field
 
 from app.config import settings
+from app.internal import discord_guild_link as glink
 from app.internal import discord_leases as leases
 from app.internal import discord_rest
 from app.internal import discord_streams as streams
@@ -182,23 +182,18 @@ async def link_guild(guild_id: str, body: GuildLink, decoded: dict = Depends(req
     org = await fstore.doc_get("organizations", body.org_id)
     if not org:
         raise HTTPException(404, "Organization not found.")
-    previous_org = await streams.resolve_guild_org(guild_id)
-    doc = {
-        "guild_id": guild_id, "org_id": body.org_id,
-        "linked_by": decoded.get("uid"), "linked_at": datetime.now(timezone.utc).isoformat(),
-        # Re-linking a server that was unlinked or removed brings it back.
-        "unlinked_at": None, "unlinked_by": None, "removed_at": None, "removed_by": None,
-    }
-    if body.guild_name and body.guild_name.strip():
-        doc["guild_name"] = body.guild_name.strip()[:100]
-    await fstore.doc_set(streams.GUILDS, guild_id, doc)
-    # Live channels in this server were placed on the previous org's nodes;
-    # left running, the reconciler would keep re-placing them there, so one
-    # org's equipment would keep serving a server that now belongs to another.
-    stopped: list[str] = []
-    if previous_org and previous_org != body.org_id:
-        stopped = await streams.stop_guild(guild_id, "server linked to another organization")
-    return {"ok": True, "guild_id": guild_id, "org_id": body.org_id, "stopped": stopped}
+    # Support override: may move a server between orgs. Re-linking a server
+    # that was unlinked or removed brings it back. Live channels placed on the
+    # previous org's nodes are stopped (glink._settle) — left running, the
+    # reconciler would keep re-placing them there.
+    out = await glink.link_and_settle(body.org_id, guild_id, body.guild_name, decoded.get("uid") or "admin",
+                                      "admin", allow_move=True, stop_reason=glink.ADMIN_RELINK_STOP_REASON)
+    uid, email = describe_actor(decoded)
+    await write_audit(uid, email, "discord.guild.link", details={
+        "guild_id": guild_id, "org_id": body.org_id, "previous_org_id": out["previous_org_id"],
+        "already_linked": out["already_linked"], "streams_stopped": len(out["streams_stopped"]), "via": "admin",
+    })
+    return {"ok": True, "guild_id": guild_id, "org_id": body.org_id, "stopped": out["streams_stopped"]}
 
 
 @router.delete("/streams/{stream_id}")