Bound the correlation debug reads so the view stops hanging
Build & Deploy / Build & push images (push) Successful in 4m3s
Build & Deploy / Deploy to VM (push) Failing after 10m25s

/admin/debug/correlation read every incident ever created, sorted them in
Python and kept 20, and separately pulled every call in the orphan window with
no cap. That worked while the collections were small. They are not small now:
Firestore kills an unbounded scan with a 503 and the request never returns, so
the debug view simply spins -- which is also what made the org backfill script
fail earlier tonight, same cause, different caller.

Incidents now come back pre-sorted from Firestore with a limit, and the orphan
scan is capped at 3000 documents. Both queries order on the single field they
already filter or sort by (updated_at, ended_at), so neither needs a composite
index -- worth preserving, since the index file from the tenancy work has not
been deployed.

Capping introduces a way to be wrong quietly: a truncated window looks exactly
like a quiet night. The payload now carries incidents_window_exhausted and
orphan_scan_truncated so a short result announces itself instead of being read
as a correlation improvement.

The AI-system filter still runs in Python, so the incident window is 10x the
requested limit rather than the limit itself.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Logan Cusano
2026-08-18 21:13:20 -04:00
co-authored by Claude Opus 5
parent c3fe2a3466
commit 90a0412066
+34 -5
View File
@@ -98,13 +98,29 @@ async def debug_correlation(
ai_systems = await _get_ai_enabled_system_ids(global_flags)
# ── Fetch recent incidents (AI-enabled systems only) ──────────────────────
all_incidents = await fstore.collection_list("incidents")
all_incidents.sort(key=lambda i: i.get("updated_at", ""), reverse=True)
# Read a bounded, already-sorted window rather than the whole collection.
# This route used to pull every incident ever created and sort in Python,
# which stopped returning at all once the collection grew — Firestore kills
# an unbounded scan with a 503 and the request just hangs. Ordering on the
# single field updated_at needs no composite index.
#
# The AI-system filter runs in Python (it's a membership test against a set
# the flags decide), so the window has to be wider than `limit` or filtering
# could empty it. 10x with a floor of 200 covers a debug view; if a fetch
# still comes back short, incidents_window_exhausted says so in the payload
# rather than quietly looking like "no incidents".
window = max(limit * 10, 200)
all_incidents = await fstore.collection_where(
"incidents", [],
order_by=[("updated_at", "DESCENDING")],
limit_to=window,
)
ai_incidents = [
i for i in all_incidents
if any(sid in ai_systems for sid in (i.get("system_ids") or []))
]
incidents = ai_incidents[:limit]
incidents_window_exhausted = len(all_incidents) >= window and len(ai_incidents) < limit
# ── Fetch all linked call docs in parallel ────────────────────────────────
all_call_ids: list[str] = []
@@ -130,9 +146,17 @@ async def debug_correlation(
# Use a single-field range query to avoid requiring a composite Firestore index;
# filter status and system in Python.
cutoff = datetime.now(timezone.utc) - timedelta(hours=orphan_hours)
recent_calls = await fstore.collection_where("calls", [
("ended_at", ">=", cutoff),
])
# Bounded for the same reason as the incident read above. The range and the
# sort are both on ended_at, which is what keeps this a single-field query
# needing no composite index.
_ORPHAN_SCAN_CAP = 3000
recent_calls = await fstore.collection_where(
"calls",
[("ended_at", ">=", cutoff)],
order_by=[("ended_at", "DESCENDING")],
limit_to=_ORPHAN_SCAN_CAP,
)
orphan_scan_truncated = len(recent_calls) >= _ORPHAN_SCAN_CAP
orphans = [
_call_summary(c) for c in recent_calls
if c.get("status") == "ended"
@@ -162,6 +186,11 @@ async def debug_correlation(
return {
"generated_at": datetime.now(timezone.utc).isoformat(),
# Both reads are capped, so say plainly when a cap was hit — otherwise a
# truncated window is indistinguishable from a quiet night.
"incidents_window_exhausted": incidents_window_exhausted,
"orphan_scan_truncated": orphan_scan_truncated,
"orphan_scan_cap": _ORPHAN_SCAN_CAP,
"incident_count": len(incident_records),
"orphaned_call_count": len(orphans),
"orphans_by_talkgroup": sorted(orphans_by_tg.values(), key=lambda x: x["count"], reverse=True),