logan/server-26
1
0
Fork 0
Code Issues 84 Pull Requests Actions Packages Projects Releases Wiki Activity

Discord perms: partial guild payload is unknown, not a deny (#225 S1 review)

Browse Source 
A guild without its @everyone role (or that role's permissions) was read
as base 0, a definite deny that would block a start. It now raises
ValueError, which S3 treats as unknown and lets the start go ahead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Logan Cusano
2026-10-05 01:57:15 -04:00
co-authored by Claude Opus 5.5
parent 09746c467b
commit 9e850fedf0
2 changed files with 22 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drb-c2-core/app/internal/discord_perms.py
+7 -2
View File
@@ -178,9 +178,14 @@ def effective_permissions(
if member_id and member_id == _sid(guild.get("owner_id")):
return ALL_PERMISSIONS, {}
# 2. Base from @everyone + the member's roles.
# 2. Base from @everyone + the member's roles. Every guild has an
# @everyone role (id == guild id) with a permissions value; without one
# the payload is partial, and reading it as "no permissions" would turn
# it into a definite deny instead of "unknown" (the plan is fail-open).
everyone_role = roles.get(guild_id)
base = parse_permissions(everyone_role.get("permissions")) if everyone_role else 0
if not guild_id or everyone_role is None or everyone_role.get("permissions") in (None, ""):
raise ValueError(f"guild payload has no @everyone role permissions (guild {guild_id or '?'})")
base = parse_permissions(everyone_role.get("permissions"))
for rid in member_role_ids:
role = roles.get(rid)
if role is not None and rid != guild_id: