2 Commits

Include renames

Author	SHA1	Message	Date
Logan Cusano	4dc3f27ac4	Fix the no-org redirect loop and swallowed Google sign-in errors ... Redirect chain traced across middleware.ts, ChromeSwitcher.tsx and AuthProvider.tsx before touching anything, per the ask. Those three were already correct as of c7f985d/2a1d52b/83416fe (middleware exempts /onboarding and /signup from the drb_session cookie gate, ChromeSwitcher sends any signed-in no-org user to /onboarding, AuthProvider only sets the cookie once an org_id claim exists). The actual loop was one file upstream of all three: app/login/page.tsx hardcoded `router.push("/dashboard")` after both the email/password and Google handlers resolved. That push races AuthProvider's async onAuthStateChanged -> getIdTokenResult -> cookie decision. For a no-org account the cookie never gets set, so middleware bounces the very next request back to /login with no explanation — the ping-pong the coordinator saw live. Fix: login page no longer navigates from the handlers. It waits on AuthProvider's own `loading`/`orgId` and redirects once claims are settled (/dashboard with org_id, /onboarding without). This also fixes a second case: a user who lands on /login already signed in (e.g. bounced there by middleware while their Firebase session was still valid) now gets routed the same way instead of sitting inert on a login form with no feedback. /onboarding itself (org-name form, single action) was already adequate as the "explain the state" screen once the loop stopped recreating it. Also, live tonight: Google sign-in was failing outright in prod with no console/network trace. app/login/page.tsx's Google handler did `catch { setError("Google sign-in failed. Try again.") }` — no binding, error discarded. Added lib/authErrors.ts: logs the raw error, and maps Firebase codes to messages that distinguish two categories — the user's own situation (popup blocked/closed, bad password, network) says "try again"; deployment misconfiguration (auth/unauthorized-domain, auth/operation-not-allowed) says so explicitly and does not suggest retrying, since retrying can't fix a missing authorized-domain entry or a disabled provider. Applied to both handlers in login/page.tsx and both in signup/page.tsx (same swallowing pattern, same fix). Per the coordinator's steer: this is diagnosis only — no popup-to-redirect fallback, no auth method change. If production is hitting auth/unauthorized-domain, that's a Firebase Console fix (drb.cusano.net -> Authorized domains), not a code fix. Nav.tsx: sign-out was only reachable from /profile. Added a profile dropdown (desktop) and drawer entries (mobile) with Profile / Refresh access / Sign out, so sign-out is reachable from anywhere in the app. "Refresh access" calls AuthProvider.refreshClaims() (already existed, already used by /onboarding after signup) so a user whose role or org was just changed server-side can pick it up without a full logout. Decision on unknown Google accounts (point 4): kept self-serve org creation via /onboarding rather than a "request access" pending state. BUSINESS_MODEL.md #2.1 already answers this for the owner: "a limited free public tier *and* full paid access without contributing... cash is the primary revenue line from day one." A pending-approval gate would contradict that — it would make org creation itself the thing being gated, when the model explicitly does not want contribution (or approval) to be the only door. Self-serve org provisioning via POST /auth/signup was already built for this (2a1d52b) and needed no further gating decision, just for the loop in front of it to stop. Reversible: no schema change, no new gating, no billing/Stripe touched. Bench: rsync'd to the WSL-native ~/drb-frontend workspace and ran `npx tsc --noEmit` there (per CLAUDE.md — the H: drive install path is not viable) — exit 0, no errors. No Python touched this pass.	2026-08-18 21:57:39 -04:00
Logan CusanoandClaude Opus 5	2a1d52b7af	Add a real signup path instead of the accidental one ... SAAS_PLAN.md 2.2: there was no /signup page. The only self-serve path was Google sign-in on /login, which auto-provisions a Firebase account with no role or org claim at all - previously that meant "viewer role, full read access" the moment the AuthProvider cookie logic (previous commit) let it through. That's closed now regardless; this commit is the other side of it - giving people an actual way in. app/signup/page.tsx: email/password (createUserWithEmailAndPassword) or Google, same visual language as /login. It only creates the Firebase account - org naming is deliberately not on this page, so every path that produces an account with no org (this one, and Google-via-/login) converges on the same next screen. app/onboarding/page.tsx: that screen. Shown to any signed-in user with no orgId (ChromeSwitcher's redirect, previous commit), collects an org name, calls the new c2api.signup() -> POST /auth/signup (routers/links.py, already shipped), then refreshClaims() to force-refetch the ID token so orgId picks up immediately and the same redirect effect sends them on to /dashboard - no manual reload needed. lib/c2api.ts also gained getOrg/updateOrg and the enrollment-token mint/list/revoke calls (routers/org.py, already shipped on the backend) and joinWaitlist (routers/waitlist.py) - none consumed yet, wired in ahead of the settings/legal commits that use them so this stays one add per concept rather than scattering client additions across later commits. /login gained a "Don't have an account? Sign up" link to /signup. This is signup plumbing, not marketing copy - pricing/plan copy (app/pricing, lib/billing.ts) is untouched in this pass, that's a separate, still-open decision (SAAS_PLAN.md section 6). Typecheck: clean (tsc --noEmit via the WSL-native ~/drb-frontend copy). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-18 20:34:04 -04:00