logan/server-26
1
0
Fork 0
Code Issues 84 Pull Requests Actions Packages Projects Releases Wiki Activity

Frontend punch-list (drb.cusano.net live review, 2026-09-07) #109

New Issue
Open
opened 2026-09-06 23:44:02 -04:00 by logan · 5 comments
logan commented 2026-09-06 23:44:02 -04:00
Owner
Copy Link
Copy Source

From a full route audit of drb-frontend (all app/ routes except the fenced /, /features, /pricing, /faq, /settings/billing, and the map internals). P1/P2 items in this list are NOT yet fixed unless noted; the honest-error-state items for /incidents and /watch shipped in the fix/frontend-map-and-error-states PR.

P1 — broken / crash-risk

  1. Zero-node org lands on a blank map. app/page.tsx:147 renders <LiveView/> for any user && orgId; LiveView.tsx:37 only has a "configured but quiet" empty state. The UI_REDESIGN.md Activation screen (chunk 10) was never built — no components/Activation.tsx. A new customer sees an empty map with no "mint a token" path.
  2. components/CallSpineEntry.tsx InlinePlayer — conditional hook. if (!hasAudio) return null (~line 33) sits between useState/useRef calls and a later useEffect → React error #310 if ever mounted with hasAudio={false}. Masked only because the parent mounts it exclusively when hasAudio is true (dead guard). Fix: delete the dead hasAudio prop+guard, or hoist the return above all hooks.
  3. /incidents raw Firestore index error — FIXED in fix/frontend-map-and-error-states (friendlyIncidentsError). Root cause still server-26 #13/#51.

P2 — misleading state / wrong data

  1. /watch alerts events tab swallowed query failures → false "No alerts triggered yet." — FIXED in the same PR. Also: RulesTab (~line 36) calls load() from the render body — move to useEffect.
  2. app/nodes/[id]/page.tsx:123 "Recent Calls" usually wrongly empty. useCalls(20) fetches 20 most-recent org-wide then filters c.node_id === id client-side. Busy multi-node org → "No calls recorded from this node" for nodes that have plenty. Needs a server-side node_id filter.
  3. app/nodes/page.tsx:44 pending-node card double-fires. <NodeCard> is a <Link>; the pending branch wraps it in a <div onClick={setConfigNode}>. Click → navigates AND tries to open the config modal; navigation wins, modal never shows. Fix: pending card not a Link, or stopPropagation.
  4. app/trips/page.tsx upcoming/past mismatch. List buckets on end_date >= today (line 176); TripCard badge uses start_date >= today (line 25). In-progress trip shows under "Upcoming" with a "Past" badge. Align both on end_date.
  5. DEFERRED drift — settings/organization. DEFERRED says the org-name Save button is disabled/no backend, but c2api.getOrg/updateOrg are wired and the button is live (page.tsx:80). Confirm PATCH /org exists on c2-core; update DEFERRED or the button 403s raw.
  6. app/calls/page.tsx (Archive) ahead of its doc. Built against GET /calls/search; UI_REDESIGN.md lists the route as BLOCKED on backend. If /calls/search isn't deployed → "Couldn't load calls: C2 API error 404". Verify the endpoint. (Possibly the user's reported /archive CORS symptom.)

P3 — visual / polish

  1. Two-tier visual seam. Token-migrated: Live, Incidents, Incident detail, Archive, Network hub. NOT migrated (hardcoded bg-gray-*, depend on the globals.css !important block): /nodes, /systems, /alerts body, /admin, /profile, /settings/*, /trips, /onboarding, /login, /signup, /waitlist. Known (DEFERRED globals.css row) but jars visibly. This is the remaining migration backlog.
  2. app/network/page.tsx is a 3-card hub, not UI_REDESIGN.md §5.6 (no Enrollment tab, still at /settings/nodes; "Bot Tokens" shows —). Scope decision.
  3. components/StatusBadge.tsx:6 offline state + admin Toggle off-state → pale-gray-on-near-white in light mode. Borderline contrast; off-toggle reads as "no control".
  4. app/trips/page.tsx:100 CreateModal has no p-4 / no inner scroll → clips on short viewports. Same for NodeConfigModal, DiscordJoinModal. Add p-4 overlay + max-h-[90vh] overflow-y-auto panel (incidents CreateModal already does).
  5. lib/types.ts — IncidentRecord.units/vehicles non-optional but Firestore omits them on older docs; incidents/[id]/page.tsx:216 already ?.-guards, contradicting the type. Make them optional.
  6. /settings/members + /settings/nodes 403 for a pure org-owner (both call /admin/users, require_admin_token; B7 gate lets them reach the page). Known (SAAS_PLAN B7); error surface is at least honest.

Generated by a frontend-audit agent.

From a full route audit of `drb-frontend` (all `app/` routes except the fenced `/`, `/features`, `/pricing`, `/faq`, `/settings/billing`, and the map internals). P1/P2 items in this list are NOT yet fixed unless noted; the honest-error-state items for `/incidents` and `/watch` shipped in the `fix/frontend-map-and-error-states` PR. ## P1 — broken / crash-risk 1. **Zero-node org lands on a blank map.** `app/page.tsx:147` renders `<LiveView/>` for any `user && orgId`; `LiveView.tsx:37` only has a "configured but quiet" empty state. The `UI_REDESIGN.md` Activation screen (chunk 10) was never built — no `components/Activation.tsx`. A new customer sees an empty map with no "mint a token" path. 2. **`components/CallSpineEntry.tsx` `InlinePlayer` — conditional hook.** `if (!hasAudio) return null` (~line 33) sits between `useState`/`useRef` calls and a later `useEffect` → React error #310 if ever mounted with `hasAudio={false}`. Masked only because the parent mounts it exclusively when `hasAudio` is true (dead guard). Fix: delete the dead `hasAudio` prop+guard, or hoist the return above all hooks. 3. **`/incidents` raw Firestore index error** — FIXED in `fix/frontend-map-and-error-states` (friendlyIncidentsError). Root cause still server-26 #13/#51. ## P2 — misleading state / wrong data 4. **`/watch` alerts events tab swallowed query failures** → false "No alerts triggered yet." — FIXED in the same PR. Also: `RulesTab` (~line 36) calls `load()` from the render body — move to `useEffect`. 5. **`app/nodes/[id]/page.tsx:123` "Recent Calls" usually wrongly empty.** `useCalls(20)` fetches 20 most-recent org-wide then filters `c.node_id === id` client-side. Busy multi-node org → "No calls recorded from this node" for nodes that have plenty. Needs a server-side `node_id` filter. 6. **`app/nodes/page.tsx:44` pending-node card double-fires.** `<NodeCard>` is a `<Link>`; the pending branch wraps it in a `<div onClick={setConfigNode}>`. Click → navigates AND tries to open the config modal; navigation wins, modal never shows. Fix: pending card not a Link, or stopPropagation. 7. **`app/trips/page.tsx` upcoming/past mismatch.** List buckets on `end_date >= today` (line 176); `TripCard` badge uses `start_date >= today` (line 25). In-progress trip shows under "Upcoming" with a "Past" badge. Align both on `end_date`. 8. **DEFERRED drift — `settings/organization`.** DEFERRED says the org-name Save button is disabled/no backend, but `c2api.getOrg`/`updateOrg` are wired and the button is live (`page.tsx:80`). Confirm `PATCH /org` exists on c2-core; update DEFERRED or the button 403s raw. 9. **`app/calls/page.tsx` (Archive) ahead of its doc.** Built against `GET /calls/search`; `UI_REDESIGN.md` lists the route as BLOCKED on backend. If `/calls/search` isn't deployed → "Couldn't load calls: C2 API error 404". Verify the endpoint. (Possibly the user's reported `/archive` CORS symptom.) ## P3 — visual / polish 10. **Two-tier visual seam.** Token-migrated: Live, Incidents, Incident detail, Archive, Network hub. NOT migrated (hardcoded `bg-gray-*`, depend on the `globals.css` `!important` block): `/nodes`, `/systems`, `/alerts` body, `/admin`, `/profile`, `/settings/*`, `/trips`, `/onboarding`, `/login`, `/signup`, `/waitlist`. Known (DEFERRED globals.css row) but jars visibly. This is the remaining migration backlog. 11. `app/network/page.tsx` is a 3-card hub, not `UI_REDESIGN.md` §5.6 (no Enrollment tab, still at `/settings/nodes`; "Bot Tokens" shows `—`). Scope decision. 12. `components/StatusBadge.tsx:6` offline state + `admin` `Toggle` off-state → pale-gray-on-near-white in light mode. Borderline contrast; off-toggle reads as "no control". 13. `app/trips/page.tsx:100` CreateModal has no `p-4` / no inner scroll → clips on short viewports. Same for `NodeConfigModal`, `DiscordJoinModal`. Add `p-4` overlay + `max-h-[90vh] overflow-y-auto` panel (incidents CreateModal already does). 14. `lib/types.ts` — `IncidentRecord.units`/`vehicles` non-optional but Firestore omits them on older docs; `incidents/[id]/page.tsx:216` already `?.`-guards, contradicting the type. Make them optional. 15. `/settings/members` + `/settings/nodes` 403 for a pure org-owner (both call `/admin/users`, `require_admin_token`; B7 gate lets them reach the page). Known (SAAS_PLAN B7); error surface is at least honest. Generated by a frontend-audit agent.
logan commented 2026-09-07 18:39:23 -04:00
Author
Owner
Copy Link
Copy Source

Live re-walk 2026-09-07 ~18:38 ET. Items 1/2/3 in this list confirmed still broken in prod — all three are backend/infra deploys, no frontend PR closed them:

  • Map (P1 #1 area): every map (/, /incidents/[id]) renders full-screen API KEY REQUIRED Carto watermarks. MAP_TILE_URL override merged in code but NEXT_PUBLIC_MAP_TILE_URL was never set in the CI build env, so prod still uses the dead Carto URL. Filed separately.
  • /watch Triggered Alerts: dead — alert_events composite index (acknowledged, org_id, triggered_at desc) never deployed. Same index throws useUnacknowledgedAlerts: FirebaseError: The query requires an index in layout.js console on every page. Blocks the whole tab + the site-wide alert bell. -> #51.
  • /calls (Archive): TypeError: Failed to fetch — CORS preflight failure, root-caused in #110.

New, lower severity (added to Version 5C/UI_AUDIT_0907b.md):

  • Stray unstyled clock (18:37:23) bottom-left of the Leaflet map on / and /incidents/[id] — no label, no styling. Leftover debug element.
  • Incident mini-card overlay collides with the leaflet zoom controls + severity legend (top-left of the map).
  • Possible transcript-block leak: incident 4d49e09c call transcript shows 1. ... 2. 10-4. 3. 5, I'm out. 4. 10-4. — looks like _build_transcript_block's {i}. segment numbering bleeding into the user-visible corrected transcript. Unconfirmed (could be Whisper). Worth checking the #102 0-based change.

Item 2 (CallSpineEntry conditional hook) and item 14 (IncidentRecord.units optional) from this list were fixed in the punch-list PRs this session.

Live re-walk 2026-09-07 ~18:38 ET. Items 1/2/3 in this list **confirmed still broken in prod** — all three are backend/infra deploys, no frontend PR closed them: - **Map (P1 #1 area):** every map (`/`, `/incidents/[id]`) renders full-screen `API KEY REQUIRED` Carto watermarks. `MAP_TILE_URL` override merged in code but `NEXT_PUBLIC_MAP_TILE_URL` was never set in the CI build env, so prod still uses the dead Carto URL. Filed separately. - **/watch Triggered Alerts:** dead — `alert_events` composite index (`acknowledged`, `org_id`, `triggered_at` desc) never deployed. Same index throws `useUnacknowledgedAlerts: FirebaseError: The query requires an index` in `layout.js` console on **every page**. Blocks the whole tab + the site-wide alert bell. -> #51. - **/calls (Archive):** `TypeError: Failed to fetch` — CORS preflight failure, root-caused in #110. New, lower severity (added to `Version 5C/UI_AUDIT_0907b.md`): - **Stray unstyled clock** (`18:37:23`) bottom-left of the Leaflet map on `/` and `/incidents/[id]` — no label, no styling. Leftover debug element. - **Incident mini-card overlay collides** with the leaflet zoom controls + severity legend (top-left of the map). - **Possible transcript-block leak:** incident `4d49e09c` call transcript shows `1. ... 2. 10-4. 3. 5, I'm out. 4. 10-4.` — looks like `_build_transcript_block`'s `{i}.` segment numbering bleeding into the user-visible corrected transcript. Unconfirmed (could be Whisper). Worth checking the `#102` 0-based change. Item 2 (`CallSpineEntry` conditional hook) and item 14 (`IncidentRecord.units` optional) from this list were fixed in the punch-list PRs this session.
logan commented 2026-09-07 18:53:19 -04:00
Author
Owner
Copy Link
Copy Source

P2 punch-list pass on branch fix/109-punchlist-p2 (local commit only, not pushed).

Item 4 — FIXED. RulesTab in app/alerts/page.tsx (not /watch) called load() from the render body. Moved to useEffect(() => { load(); }, []); load() already self-guards on its loaded state flag, so [] deps are honest. Added useEffect to the react import.

Item 6 — ALREADY FIXED (verified). components/NodeCard.tsx already has a linkToDetail?: boolean prop (defaults true) that drops the <Link> wrapper when false, and app/nodes/page.tsx:45 already passes linkToDetail={false} on the pending branch. The wrapping <div onClick={() => setConfigNode(n)}> now opens the config modal without navigating. No change needed.

Item 8 — ENDPOINT EXISTS; button is correctly wired. drb-c2-core/app/routers/org.py:48 @router.patch("") on prefix /org → update_org(OrgUpdateBody, Depends(require_org_owner_token)). Frontend c2api.updateOrg (lib/c2api.ts:306) does PATCH /org with {name}. app/settings/organization/page.tsx Save button is live and guarded (!canEdit / empty / unchanged disable it). No frontend change made. The stale entry is DEFERRED.md:35 ("no backend to save to — save button is disabled"), which lives at the Version 5C root, outside the Server repo and this worktree — cannot commit it here. Flagging for someone with repo-root access to correct that row.

Item 5 — deferred with TODO (limit raised). useCalls in lib/useCalls.ts is a direct Firestore query (where org_id ==, optional started_at range, orderBy started_at desc, limit). Adding where('node_id','==', id) alongside the existing org_id equality + started_at orderBy would require a brand-new composite index, so took the safe path: app/nodes/[id]/page.tsx:123 now calls useCalls(200) (was 20) and keeps the client-side c.node_id === id filter, with a // TODO(server-26#109 item5) comment. Proper fix is a server-side node_id filter.

Item 7 — ALREADY FIXED (verify only). app/trips/page.tsx: TripCard badge (line 27) uses trip.end_date >= today; list buckets (lines 178-179) use end_date. Consistent. No change.

Items 1-3, 9-15 out of scope for this pass. Files changed: drb-frontend/app/alerts/page.tsx, drb-frontend/app/nodes/[id]/page.tsx.

P2 punch-list pass on branch `fix/109-punchlist-p2` (local commit only, not pushed). **Item 4 — FIXED.** `RulesTab` in `app/alerts/page.tsx` (not `/watch`) called `load()` from the render body. Moved to `useEffect(() => { load(); }, [])`; `load()` already self-guards on its `loaded` state flag, so `[]` deps are honest. Added `useEffect` to the react import. **Item 6 — ALREADY FIXED (verified).** `components/NodeCard.tsx` already has a `linkToDetail?: boolean` prop (defaults true) that drops the `<Link>` wrapper when false, and `app/nodes/page.tsx:45` already passes `linkToDetail={false}` on the pending branch. The wrapping `<div onClick={() => setConfigNode(n)}>` now opens the config modal without navigating. No change needed. **Item 8 — ENDPOINT EXISTS; button is correctly wired.** `drb-c2-core/app/routers/org.py:48` `@router.patch("")` on prefix `/org` → `update_org(OrgUpdateBody, Depends(require_org_owner_token))`. Frontend `c2api.updateOrg` (`lib/c2api.ts:306`) does `PATCH /org` with `{name}`. `app/settings/organization/page.tsx` Save button is live and guarded (`!canEdit` / empty / unchanged disable it). No frontend change made. The stale entry is `DEFERRED.md:35` ("no backend to save to — save button is disabled"), which lives at the Version 5C root, outside the Server repo and this worktree — cannot commit it here. Flagging for someone with repo-root access to correct that row. **Item 5 — deferred with TODO (limit raised).** `useCalls` in `lib/useCalls.ts` is a direct Firestore query (`where org_id ==`, optional `started_at` range, `orderBy started_at desc`, `limit`). Adding `where('node_id','==', id)` alongside the existing `org_id` equality + `started_at` orderBy would require a brand-new composite index, so took the safe path: `app/nodes/[id]/page.tsx:123` now calls `useCalls(200)` (was 20) and keeps the client-side `c.node_id === id` filter, with a `// TODO(server-26#109 item5)` comment. Proper fix is a server-side node_id filter. **Item 7 — ALREADY FIXED (verify only).** `app/trips/page.tsx`: `TripCard` badge (line 27) uses `trip.end_date >= today`; list buckets (lines 178-179) use `end_date`. Consistent. No change. Items 1-3, 9-15 out of scope for this pass. Files changed: `drb-frontend/app/alerts/page.tsx`, `drb-frontend/app/nodes/[id]/page.tsx`.
logan commented 2026-10-04 20:09:02 -04:00
Author
Owner
Copy Link
Copy Source

Item 13, DiscordJoinModal part: PR #220 removes that modal. The new picker modal has p-4 on the overlay and a max-h-[90vh] panel with an inner scroll. The trips CreateModal and NodeConfigModal parts of item 13 are not touched.

Item 13, `DiscordJoinModal` part: PR #220 removes that modal. The new picker modal has `p-4` on the overlay and a `max-h-[90vh]` panel with an inner scroll. The trips CreateModal and NodeConfigModal parts of item 13 are not touched.
logan added the area/frontend
priority
p2
type
tracking
 labels 2026-10-05 02:04:46 -04:00
logan commented 2026-10-05 02:34:27 -04:00
Author
Owner
Copy Link
Copy Source

Item 2 (the InlinePlayer conditional hook) was already fixed on main before PR #253. At a75149b, InlinePlayer had no hasAudio prop or guard, and its only early return (if (error)) came after every hook. PR #253 moves it to components/InlinePlayer.tsx and keeps all hooks above any return. No separate fix was needed.

Item 2 (the `InlinePlayer` conditional hook) was already fixed on main before PR #253. At a75149b, `InlinePlayer` had no `hasAudio` prop or guard, and its only early return (`if (error)`) came after every hook. PR #253 moves it to `components/InlinePlayer.tsx` and keeps all hooks above any return. No separate fix was needed.
logan commented 2026-10-25 21:32:22 -04:00
Author
Owner
Copy Link
Copy Source

UX pass 2026-10-25 status: item 1 (Activation screen) still unbuilt -- components/Activation.tsx absent; LiveView.tsx:592 comment still refers to it. Item 5 only mitigated (window now 200, still client-side filter) -> filed as #288 with the node-page loading bug. Items 2, 6, 7 verified fixed. New from this pass: #283-#289.

UX pass 2026-10-25 status: item 1 (Activation screen) still unbuilt -- components/Activation.tsx absent; LiveView.tsx:592 comment still refers to it. Item 5 only mitigated (window now 200, still client-side filter) -> filed as #288 with the node-page loading bug. Items 2, 6, 7 verified fixed. New from this pass: #283-#289.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/ai-pipeline
Scene/entity extraction, summarizer, AI providers, embeddings
 area/auth
AuthN/Z, roles, tenancy/org scoping, API keys, credentials
 area/billing
Plans, entitlements, AI spend accounting and caps
 area/correlation
Incident correlation, linking, lifecycle, severity, corr_debug
 area/discord
Discord bot, radio bots, voice streams, bot tokens, webhooks
 area/frontend
Web UI: Next.js app and the edge-node local dashboard
 area/governance
Board process, minutes, unattended runner, agent tooling
 area/growth
Go-to-market, outreach, cold email, discovery conversations
 area/infra-deploy
CI/CD, VM, registry, Firestore rules/indexes deploy, Terraform/Caddy
 area/legal
ToS, retention, licences/DAAs, CAN-SPAM, E&O, name suppression
 area/map
Live map: pins, paths, tiles, legend, geocoding
 area/mqtt
Node-C2 MQTT, checkins, commands, node sweeper, dynsec
 area/node-ota
Node install, enrollment, OTA updater, image skew
 area/osint
External feeds: cameras, 511, ADS-B, AIS, outages, and their licences
 area/recording-audio
Call capture, boundaries, PulseAudio, ring buffer, trimming, attribution
 area/sdr-radio
OP25 decode, SDR hardware/tuning, conventional, second SDR, mesh radio
 area/transcription
STT, transcript correction, place verification, name accuracy
 board
Board process: minutes and board-filed items
 board:agenda
Needs board scoping at the next sitting; CEO removes the label once scoped
 minutes:draft
One exec pre-read, closed by CEO
 minutes:final
CEO ruling; open until enacted
 role:ceo
Filed by the CEO
 role:cfo
Filed by the CFO
 role:cio
Filed by the CIO
 role:ciso
Filed by the CISO
 role:cmo
Filed by the CMO
 role:coo
Filed by the COO
 role:cto
Filed by the CTO
kind
behavior-bug
Wrong product behavior; the instrument reads it correctly
kind
measurement-bug
Corrupts the recording/instrument (debug data, evals, health checks), not behavior
priority
p0
Drop everything: prod broken, live exposure, or owner-ruled P0
priority
p1
Next up: blocks a gate, a customer, or core incident quality
priority
p2
Normal: real defect or planned work, schedule in turn
priority
p3
Low: minor, cosmetic, or someday
status
blocked
Waiting on an external party, spend, or another issue
status
in-progress
Branch or PR open against it
status
needs-decision
Waiting on an owner or board ruling before work
status
needs-info
Root cause or repro unknown; needs a reading first
type
bug
Something built is wrong: code, data, or a measurement
type
chore
Maintenance, refactor, tests, pinning, cleanup: no user-visible change
type
decision
A ruling to make or record: board minutes, owner calls, legal reviews
type
docs
Docs, runbooks, CLAUDE.md, skills, SOPs
type
feature
New capability or an extension of an existing one
type
security
Security, privacy, credential or tenant-isolation exposure
type
tracking
Tracker, checklist, initiative or punch-list spanning several changes
No labels area/frontend
priority
p2
type
tracking
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
logan
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: logan/server-26#109