No pre-merge frontend typecheck: no Node on the authoring box, no lockfile, CI only on main #207

New Issue

2026-10-04T17:59:22-04:00

logan commented

2026-10-04 17:59:22 -04:00

Found 2026-10-04 finishing the live ops wall (feat/live-ops-wall).

What: there is no way to typecheck the frontend before merge.

The authoring box (now macOS) has no Node.js/npm at all (which node -> not found; no Homebrew/nvm/volta node).
drb-frontend/ has no package-lock.json, so npm ci cannot run anywhere; npm install resolves unpinned ^ ranges fresh each time.
No PR-time CI: .gitea/workflows/deploy.yml runs only on push to main. The first typecheck a change ever gets is next build inside the frontend Docker build after merge, which then fails the deploy instead of the PR.
The verify skill section 4 already says frontend typecheck is unverified, and still describes the box as Linux.

Impact: every frontend PR (e.g. the live ops wall, ~2,000 TS lines) merges with zero type checking; a type error surfaces as a failed main build.

Fix shape (pick one): (a) a pull_request workflow job that runs npm install && npx tsc --noEmit in drb-frontend (no deploy, no secrets); or (b) owner installs Node on the authoring box and commits a lockfile so npm ci + npm run typecheck is reproducible. Update the verify skill either way.

Found 2026-10-04 finishing the live ops wall (feat/live-ops-wall). **What:** there is no way to typecheck the frontend before merge. - The authoring box (now macOS) has no Node.js/npm at all (`which node` -> not found; no Homebrew/nvm/volta node). - `drb-frontend/` has no `package-lock.json`, so `npm ci` cannot run anywhere; `npm install` resolves unpinned `^` ranges fresh each time. - No PR-time CI: `.gitea/workflows/deploy.yml` runs only on push to `main`. The first typecheck a change ever gets is `next build` inside the frontend Docker build **after merge**, which then fails the deploy instead of the PR. - The `verify` skill section 4 already says frontend typecheck is unverified, and still describes the box as Linux. **Impact:** every frontend PR (e.g. the live ops wall, ~2,000 TS lines) merges with zero type checking; a type error surfaces as a failed main build. **Fix shape (pick one):** (a) a `pull_request` workflow job that runs `npm install && npx tsc --noEmit` in `drb-frontend` (no deploy, no secrets); or (b) owner installs Node on the authoring box and commits a lockfile so `npm ci` + `npm run typecheck` is reproducible. Update the `verify` skill either way.

logan referenced this issue

2026-10-04 17:59:35 -04:00

Live ops wall + pluggable camera providers with licence gating (server-26#198) #208

logan referenced this issue

2026-10-04 18:10:26 -04:00

Mint panel install command still puts the enrollment token on the command line (node-26#18 server half) #215

logan referenced this issue

2026-10-05 00:30:06 -04:00

Discord: customers shouldn't need the main DRB bot in their server — radio bots (via C2) should cover linking, channel directory and permission checks #225

logan added the area/frontend area/infra-deploy

priority

p2