Live wall: minor UI follow-ups from #208 review (nested link in button, unclamped 511 bbox, no-CORS origin latch) #212

New Issue

2026-10-04T18:07:43-04:00

logan commented

2026-10-04 18:07:43 -04:00

Found reviewing PR #208 (feat/live-ops-wall), not fixed there. All low severity.

Attribution link nested in a button. CameraFeed renders the provider credit as an <a> on the frame; CameraTile (components/live/WallPanels.tsx) and CameraPopupBody (MapView.tsx) wrap CameraFeed in a <button>. Invalid HTML, and clicking the credit link also fires the tile's open-camera click.
/traffic/511 bbox not clamped (pre-existing, lib/use511.ts): zoomed-out map bounds exceed +/-180/90, the endpoint answers 422 and the Traffic Events layer shows "could not reach server". #208 clamps the camera layer (lib/useCameras.ts) only; same one-line fix applies.
No-CORS origin latch (CameraFeed.tsx): any still load error with crossOrigin adds the whole origin to noCorsOrigins for the session, so one camera that is down disables frozen-frame detection for every camera on that provider's host.
"Camera" breadcrumb in LiveView is enabled with a no-op click while a camera is open (it is the current level; should be non-interactive like the others' active state).

Found reviewing PR #208 (feat/live-ops-wall), not fixed there. All low severity. 1. **Attribution link nested in a button.** `CameraFeed` renders the provider credit as an `<a>` on the frame; `CameraTile` (components/live/WallPanels.tsx) and `CameraPopupBody` (MapView.tsx) wrap `CameraFeed` in a `<button>`. Invalid HTML, and clicking the credit link also fires the tile's open-camera click. 2. **`/traffic/511` bbox not clamped** (pre-existing, `lib/use511.ts`): zoomed-out map bounds exceed +/-180/90, the endpoint answers 422 and the Traffic Events layer shows "could not reach server". #208 clamps the camera layer (`lib/useCameras.ts`) only; same one-line fix applies. 3. **No-CORS origin latch** (`CameraFeed.tsx`): any still load error with `crossOrigin` adds the whole origin to `noCorsOrigins` for the session, so one camera that is down disables frozen-frame detection for every camera on that provider's host. 4. **"Camera" breadcrumb** in LiveView is enabled with a no-op click while a camera is open (it is the current level; should be non-interactive like the others' active state). Refs #198, PR #208.

logan added the area/frontend area/osint

labels 2026-10-05 02:05:03 -04:00

Sign in to join this conversation.