Discord picker: 'Needs fix' text says 'then try again' but Start stays disabled until the small footer Re-check is clicked #256

New Issue

2026-10-05T02:43:29-04:00

logan commented

2026-10-05 02:43:29 -04:00

Found in QA of PR #250 (#225 S4), e54191a.

drb-frontend/lib/discordPicker.ts fixSentence returns c2-core's fix verbatim, and discord_streams._fix_text ends it with "then try again." The picker shows it under the channel (VoiceCheckBits.tsx FixText) and as the per-bot line (BotDetails). But on a definite deny Start is disabled (NodeDiscordRadio.tsx definiteDeny; StreamsPanel.tsx blocksStart(verdict)) and the badges never refresh on their own — only the grey "Re-check" link in the CheckFooter at the bottom of the server list (VoiceCheckBits.tsx CheckFooter) reloads them. An org owner who fixes the permission in Discord and follows the instruction ('try again') faces a greyed-out button; only the button tooltip mentions Re-check, and tooltips are invisible on touch.

Fix: have fixSentence replace a trailing 'then try again' with 'then press Re-check' (or render the Re-check button inline in FixText). Related: #251 (backend snapshot cache keeps refusing for up to 2 min after the fix; /voice-check refresh=1 bypasses it, so Re-check is the right path).

Found in QA of PR #250 (#225 S4), e54191a. drb-frontend/lib/discordPicker.ts `fixSentence` returns c2-core's `fix` verbatim, and discord_streams._fix_text ends it with "then try again." The picker shows it under the channel (VoiceCheckBits.tsx FixText) and as the per-bot line (BotDetails). But on a definite deny Start is disabled (NodeDiscordRadio.tsx `definiteDeny`; StreamsPanel.tsx `blocksStart(verdict)`) and the badges never refresh on their own — only the grey "Re-check" link in the CheckFooter at the bottom of the server list (VoiceCheckBits.tsx CheckFooter) reloads them. An org owner who fixes the permission in Discord and follows the instruction ('try again') faces a greyed-out button; only the button tooltip mentions Re-check, and tooltips are invisible on touch. Fix: have fixSentence replace a trailing 'then try again' with 'then press Re-check' (or render the Re-check button inline in FixText). Related: #251 (backend snapshot cache keeps refusing for up to 2 min after the fix; /voice-check refresh=1 bypasses it, so Re-check is the right path).

logan added the area/discord area/frontend

labels 2026-10-05 02:43:33 -04:00

logan referenced this issue from a commit

2026-10-05 03:09:53 -04:00

S7: OAuth start/options accept system_id; Discord picker QA fixes (server-26#225, #256 #257 #258)

logan referenced a pull request that will close this issue