Map rail header doesn't say 'filtered' when the wall filter is on (follow-up to #235) #268

Closed
opened 2026-10-05 03:11:52 -04:00 by logan · 1 comment
Owner

PR #267 (#235) feeds MapView a filtered incident list, so the rail's count already follows the filter. The rail header itself is inside drb-frontend/components/MapView.tsx, though, and that file was owned by #184-map in the same batch, so #267 didn't edit it. The "Filtered: N of M" label sits in the filter row directly above the map, and the KPI bar reads "N of M active · filtered".

Fix: add an optional filteredFrom?: number prop to MapView. When it is set, the rail header shows "N of M · filtered". In LiveView, pass activeIncidents.length while filtered.active is true.

Small. Do it once MapView isn't being edited by another in-flight item.

PR #267 (#235) feeds MapView a filtered incident list, so the rail's count already follows the filter. The rail header itself is inside `drb-frontend/components/MapView.tsx`, though, and that file was owned by #184-map in the same batch, so #267 didn't edit it. The "Filtered: N of M" label sits in the filter row directly above the map, and the KPI bar reads "N of M active · filtered". Fix: add an optional `filteredFrom?: number` prop to MapView. When it is set, the rail header shows "N of M · filtered". In LiveView, pass `activeIncidents.length` while `filtered.active` is true. Small. Do it once MapView isn't being edited by another in-flight item.
logan added the
type
feature
area/map
priority
p3
labels 2026-10-05 03:11:53 -04:00
Author
Owner

Fixed in PR #280 (merge 4916678). Live in prod.

Fixed in PR #280 (merge 4916678). Live in prod.
logan closed this issue 2026-10-05 04:08:49 -04:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: logan/server-26#268