Live wall: IncidentPanel says "active" and a running elapsed clock for a resolved incident opened by link #275

Closed
opened 2026-10-05 03:29:48 -04:00 by logan · 1 comment
Owner

Found reviewing PR #272 (#239). A resolved incident opened from an #inc= link now renders in the live wall's IncidentPanel under a "Resolved HH:MM" banner, but the panel itself still says it is live:

  • drb-frontend/components/live/WallPanels.tsx IncidentPanel header: {onAir ? "ON AIR" : "active"} is hard-coded, so a resolved incident reads active directly under the Resolved banner.
  • The header shows elapsed(inc.started_at) — keeps counting up from start for an incident that has ended (should be duration started→resolved_at).
  • "Nearest cameras" / radar show live feeds now, not at incident time — fine for active, misleading for a resolved incident (label or hide).

Not fixed in #272 because WallPanels.tsx was owned by #236 in that batch.

Fix: IncidentPanel reads status/resolved_at (IncidentRecord has status: "active" | "resolved"; resolved_at is written by the correlator) — label "resolved", show duration, caveat live camera/radar sections.

Acceptance: open #inc=<resolved id> on /live — no surface in the panel claims the incident is active or still running.

Found reviewing PR #272 (#239). A resolved incident opened from an `#inc=` link now renders in the live wall's IncidentPanel under a "Resolved HH:MM" banner, but the panel itself still says it is live: - `drb-frontend/components/live/WallPanels.tsx` IncidentPanel header: `{onAir ? "ON AIR" : "active"}` is hard-coded, so a resolved incident reads **active** directly under the Resolved banner. - The header shows `elapsed(inc.started_at)` — keeps counting up from start for an incident that has ended (should be duration started→resolved_at). - "Nearest cameras" / radar show live feeds *now*, not at incident time — fine for active, misleading for a resolved incident (label or hide). Not fixed in #272 because WallPanels.tsx was owned by #236 in that batch. Fix: IncidentPanel reads `status`/`resolved_at` (IncidentRecord has `status: "active" | "resolved"`; resolved_at is written by the correlator) — label "resolved", show duration, caveat live camera/radar sections. Acceptance: open `#inc=<resolved id>` on /live — no surface in the panel claims the incident is active or still running.
logan added the
type
bug
area/maparea/frontend
priority
p3
kind
behavior-bug
labels 2026-10-05 03:29:48 -04:00
Author
Owner

Fixed in PR #280 (merge 4916678). Live in prod.

Fixed in PR #280 (merge 4916678). Live in prod.
logan closed this issue 2026-10-05 04:08:49 -04:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: logan/server-26#275