logan/server-26
1
0
Fork 0
Code Issues 84 Pull Requests Actions Packages Projects Releases Wiki Activity

/upload has no idempotency: a retried upload re-runs Whisper/Gemini/correlation on the same call_id #302

New Issue
Closed
opened 2026-10-27 20:14:57 -04:00 by logan · 1 comment
logan commented 2026-10-27 20:14:57 -04:00
Owner
Copy Link
Copy Source

Found by drb-audio-review on node-26#44 (edge branch fix/44-upload-spool, commit 6b884d5).

The edge node now retries uploads. If C2 already wrote to GCS but the node timed out or was stopped before reading the response, the node counts it as failed and uploads again. routers/upload.py (~L69-110) has no idempotency check, so the retry runs transcription, extraction and correlation a second time for the same call_id. That is double AI spend (corrupts the server-26#45 cost measurement) and the same double-link shape as server-26#131.

Fix: in /upload, still write the new GCS object, but skip the pipeline when the call doc already has audio_gcs_uri or intelligence_started_at.

Found by drb-audio-review on node-26#44 (edge branch `fix/44-upload-spool`, commit 6b884d5). The edge node now retries uploads. If C2 already wrote to GCS but the node timed out or was stopped before reading the response, the node counts it as failed and uploads again. `routers/upload.py` (~L69-110) has no idempotency check, so the retry runs transcription, extraction and correlation a second time for the same call_id. That is double AI spend (corrupts the server-26#45 cost measurement) and the same double-link shape as server-26#131. Fix: in /upload, still write the new GCS object, but skip the pipeline when the call doc already has `audio_gcs_uri` or `intelligence_started_at`.
logan added the
type
bug
area/correlationarea/ai-pipeline
priority
p2
kind
behavior-bug
 labels 2026-10-27 20:14:57 -04:00
logan commented 2026-11-08 21:51:17 -05:00
Author
Owner
Copy Link
Copy Source

Fixed in ec35d80, deployed to prod as 4fab959 on 2026-11-08 (/health confirms).

Fixed in ec35d80, deployed to prod as 4fab959 on 2026-11-08 (/health confirms).
logan removed the
priority
p2
 label 2026-11-08 21:51:17 -05:00
logan closed this issue 2026-11-08 21:51:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/ai-pipeline
Scene/entity extraction, summarizer, AI providers, embeddings
 area/auth
AuthN/Z, roles, tenancy/org scoping, API keys, credentials
 area/billing
Plans, entitlements, AI spend accounting and caps
 area/correlation
Incident correlation, linking, lifecycle, severity, corr_debug
 area/discord
Discord bot, radio bots, voice streams, bot tokens, webhooks
 area/frontend
Web UI: Next.js app and the edge-node local dashboard
 area/governance
Board process, minutes, unattended runner, agent tooling
 area/growth
Go-to-market, outreach, cold email, discovery conversations
 area/infra-deploy
CI/CD, VM, registry, Firestore rules/indexes deploy, Terraform/Caddy
 area/legal
ToS, retention, licences/DAAs, CAN-SPAM, E&O, name suppression
 area/map
Live map: pins, paths, tiles, legend, geocoding
 area/mqtt
Node-C2 MQTT, checkins, commands, node sweeper, dynsec
 area/node-ota
Node install, enrollment, OTA updater, image skew
 area/osint
External feeds: cameras, 511, ADS-B, AIS, outages, and their licences
 area/recording-audio
Call capture, boundaries, PulseAudio, ring buffer, trimming, attribution
 area/sdr-radio
OP25 decode, SDR hardware/tuning, conventional, second SDR, mesh radio
 area/transcription
STT, transcript correction, place verification, name accuracy
 board
Board process: minutes and board-filed items
 board:agenda
Needs board scoping at the next sitting; CEO removes the label once scoped
 minutes:draft
One exec pre-read, closed by CEO
 minutes:final
CEO ruling; open until enacted
 role:ceo
Filed by the CEO
 role:cfo
Filed by the CFO
 role:cio
Filed by the CIO
 role:ciso
Filed by the CISO
 role:cmo
Filed by the CMO
 role:coo
Filed by the COO
 role:cto
Filed by the CTO
kind
behavior-bug
Wrong product behavior; the instrument reads it correctly
kind
measurement-bug
Corrupts the recording/instrument (debug data, evals, health checks), not behavior
priority
p0
Drop everything: prod broken, live exposure, or owner-ruled P0
priority
p1
Next up: blocks a gate, a customer, or core incident quality
priority
p2
Normal: real defect or planned work, schedule in turn
priority
p3
Low: minor, cosmetic, or someday
status
blocked
Waiting on an external party, spend, or another issue
status
in-progress
Branch or PR open against it
status
needs-decision
Waiting on an owner or board ruling before work
status
needs-info
Root cause or repro unknown; needs a reading first
type
bug
Something built is wrong: code, data, or a measurement
type
chore
Maintenance, refactor, tests, pinning, cleanup: no user-visible change
type
decision
A ruling to make or record: board minutes, owner calls, legal reviews
type
docs
Docs, runbooks, CLAUDE.md, skills, SOPs
type
feature
New capability or an extension of an existing one
type
security
Security, privacy, credential or tenant-isolation exposure
type
tracking
Tracker, checklist, initiative or punch-list spanning several changes
No labels area/ai-pipeline area/correlation
kind
behavior-bug
type
bug
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
logan
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: logan/server-26#302