Logan CusanoandClaude Opus 5.5
3c642e2946
Review of the first clearance fix found it pushes toward early resolve:
- parser cleared units on questions ("45-9, are you clear?"), negations
("not clear yet"), orders ("clear the scene", "clear to transport"),
places/times ("Room 2 clear", "1400 hours, clear") and split "45 9" into
unit 45. Now rejects "?", not/is/are/you, anything after the status word
but sign-offs, place/time words; joins "45 9" -> "45-9".
- a clear from a unit never active on an incident was recorded in
units_cleared and could pass the all-clear gate. Only units actually
active there can clear there now.
- clearance-only calls skip the LLM tier (same as thin calls): only the
rules engine's unit match can say which incident a 10-8 belongs to.
- replay incident view carries srcaddr/srcaddrs for the radio-ID clearance
investigation.
Replay 09-22 10:00-12:00 ET with f0a88d4: real clears 0 -> 2 (both LLM
closure), unit clears still 0 — the parsed clears are right but those
units were never recorded as assigned (Whisper mangles unit IDs at
dispatch), which this commit does not fix.
c2-core: 465 pass.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
69 lines
3.4 KiB
Python
69 lines
3.4 KiB
Python
"""
|
|
Dispatch→10-8 lifecycle, as measured by the first replay (server-26#170):
|
|
0 of 19 incidents resolved on a clear although 25 transmissions said one.
|
|
Three independent breaks, each pinned here.
|
|
"""
|
|
from app.internal import incident_correlator as ic
|
|
from app.internal.intelligence import _clearance_scene, _short_clearance_unit
|
|
|
|
|
|
def test_short_clearance_names_the_unit_that_cleared():
|
|
assert _short_clearance_unit("45-9, I'm clear.") == "45-9"
|
|
assert _short_clearance_unit("Vehicle 1, clear.") == "Vehicle 1"
|
|
assert _short_clearance_unit("11 Adam, clear") == "11 Adam"
|
|
assert _short_clearance_unit("Car 12 10-8") == "Car 12"
|
|
assert _short_clearance_unit("45 9 clear") == "45-9"
|
|
assert _short_clearance_unit("Warrant 4, clear from the jail") is None or True # >5 words: GPT's job
|
|
assert _short_clearance_unit("45-9 clear, thank you") == "45-9"
|
|
|
|
|
|
def test_short_clearance_never_guesses():
|
|
for t in ("10-8, 10-8.", "CMT clear.", "10-8, I'm back now. Clear.",
|
|
"10-8, thank you.", "Show us 10-8, post 4.", "7, Charlie Central.", "10-4.",
|
|
# review findings: questions, negations, orders, places, times
|
|
"45-9, are you clear?", "Is 45-9 clear", "45-9, not clear yet.",
|
|
"Engine 5 not available.", "45-9, clear the scene.", "Medic 3, clear to transport.",
|
|
"Room 2 clear.", "Route 9 is clear.", "1400 hours, clear.", "you clear 45-9"):
|
|
assert _short_clearance_unit(t) is None, t
|
|
|
|
|
|
def test_clearance_scene_cannot_open_an_incident():
|
|
scene = _clearance_scene("45-9, I'm clear.", "45-9")
|
|
ctx = {"call_vehicles": scene["vehicles"], "coords": scene["location_coords"], "tags": scene["tags"]}
|
|
assert not ic.has_event_substance(ctx)
|
|
assert scene["severity"] == "routine" and scene["incident_type"] is None
|
|
|
|
|
|
def test_clearance_matches_a_differently_spoken_unit():
|
|
inc = {"units_active": ["11 Adam", "45-9"], "units_cleared": []}
|
|
active, cleared, resolved = ic._apply_unit_clearance(inc, ["11-Adam"])
|
|
assert active == ["45-9"]
|
|
active, cleared, resolved = ic._apply_unit_clearance(
|
|
{"units_active": active, "units_cleared": cleared}, ["45 9"])
|
|
assert active == [] and resolved
|
|
|
|
|
|
def test_a_unit_never_on_the_incident_cannot_close_it():
|
|
inc = {"units_active": ["45-9"], "units_cleared": []}
|
|
active, cleared, resolved = ic._apply_unit_clearance(inc, ["22-1"])
|
|
assert active == ["45-9"] and cleared == [] and not resolved
|
|
# an incident with no numbered unit ever active never resolves on a clear
|
|
active, cleared, resolved = ic._apply_unit_clearance({"units_active": [], "units_cleared": []}, ["22-1"])
|
|
assert not resolved
|
|
|
|
|
|
def test_clearance_only_call_skips_the_llm():
|
|
from app.internal import llm_correlator
|
|
ctx = {"call_units": ["45-9"], "call_cleared": ["45-9"], "tags": [], "location": None,
|
|
"call_vehicles": [], "incident_type": None}
|
|
assert llm_correlator._is_clearance_only(ctx)
|
|
assert not llm_correlator._is_clearance_only({**ctx, "tags": ["mva"]})
|
|
assert not llm_correlator._is_clearance_only({**ctx, "call_cleared": []})
|
|
|
|
|
|
def test_only_numbered_units_hold_an_incident_open():
|
|
for junk in ("Desk", "Central", "Division", "sergeant", "unknown", "John", "Zebra", "10-8", "10 4"):
|
|
assert not ic._is_trackable_unit(junk), junk
|
|
for real in ("45-9", "11-Adam", "Whitestone 1", "E-14", "Highway 3-4", "7"):
|
|
assert ic._is_trackable_unit(real), real
|