logan/node-26
1
0
Fork 0
Code Issues 14 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

discord_radio: presence follows voice; name why a voice join fails #38

Merged
logan merged 2 commits from fix/discord-voice-join into main 2026-10-04 22:52:31 -04:00
Conversation 1 Commits 2 Files Changed 3
+153 -8
2 Commits
Author SHA1 Message Date
Logan CusanoandClaude Opus 5.5 2065446393 discord_radio: don't count the bot's own voice state toward a full channel; timeout text points at the handshake
CI / lint (push) Successful in 8s
Details
CI / lint (pull_request) Successful in 10s
Details
CI / test-op25 (push) Successful in 14s
Details
CI / test-op25 (pull_request) Successful in 16s
Details
CI / test (push) Successful in 48s
Details
CI / test (pull_request) Successful in 47s
Details 
Permissions are pre-checked now, so a connect timeout is the voice handshake
(pre-2.7 discord.py: DAVE close 4017 retried to the 30s timeout) or UDP egress,
not permissions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-04 22:49:52 -04:00
Logan CusanoandClaude Opus 5.5 786e06a7a3 discord_radio: presence follows voice; name the reason a voice join fails
CI / lint (push) Successful in 6s
Details
CI / test-op25 (push) Successful in 14s
Details
CI / lint (pull_request) Successful in 7s
Details
CI / test-op25 (pull_request) Successful in 14s
Details
CI / test (push) Successful in 47s
Details
CI / test (pull_request) Successful in 43s
Details 
Live symptom: the radio bot shows "Listening to <system>" but is not in the
voice channel.

- Presence was set once on the first successful join and never cleared, so a
  bot whose voice dropped (or whose rejoin kept failing) still looked healthy.
  Presence is now synced at the end of every reconcile: set only while a voice
  connection for that bot is up, cleared otherwise.
- Pre-check the bot's permissions (View Channel, Connect, Speak) and the
  channel's user limit before joining. Discord silently ignores a join the bot
  may not make; discord.py then times out after 30s and the admin page read
  "Could not connect to the voice channel (TimeoutError: )". Now: code
  missing_permissions / channel_full with the missing permission named.
- A connect timeout gets its own code (connect_timeout) and readable text.
- requirements: discord.py[voice]>=2.7 — Discord has required DAVE E2EE voice
  since 2026-03-01 and 2.7 is the first discord.py with it (the extra pulls
  davey). Today's resolution was already 2.7.1 + davey 0.1.6; this stops an
  older resolution from ever being accepted.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-04 22:42:39 -04:00