Discord multi-stream follow-ups: /leave stream: rough edges; find_channel_stream ignores org_id #229

New Issue

2026-10-05T00:40:30-04:00

logan commented

2026-10-05 00:40:30 -04:00

Found reviewing PR #227 (multi-stream per voice channel). None block merge.

/leave stream:<freeform text> that fails STREAM_ID_PATTERN gets a 422 from c2-core; c2_client.stop_guild turns that into None and the bot replies "Could not reach DRB" (misleading). Validate in the bot or map 422 to "Pick a stream from the list".
/leave channel:X stream:Y silently ignores channel and stops Y even if Y is in another channel (radio.py leave). Either refuse the mismatch or document it.
discord_streams.find_channel_stream filters by guild/channel/system but not org_id. If a guild is relinked to another org, an add of the same system restarts the OLD org's stopped stream doc and rewrites its org_id instead of creating a fresh one. Filter on org_id (stopped docs of another org should be left alone).

Related: #228 (mode kept on re-add/move), #223 (per-node cap race), #213.

Found reviewing PR #227 (multi-stream per voice channel). None block merge. 1. `/leave stream:<freeform text>` that fails `STREAM_ID_PATTERN` gets a 422 from c2-core; `c2_client.stop_guild` turns that into `None` and the bot replies "Could not reach DRB" (misleading). Validate in the bot or map 422 to "Pick a stream from the list". 2. `/leave channel:X stream:Y` silently ignores `channel` and stops Y even if Y is in another channel (radio.py `leave`). Either refuse the mismatch or document it. 3. `discord_streams.find_channel_stream` filters by guild/channel/system but not `org_id`. If a guild is relinked to another org, an add of the same system restarts the OLD org's stopped stream doc and rewrites its `org_id` instead of creating a fresh one. Filter on org_id (stopped docs of another org should be left alone). Related: #228 (mode kept on re-add/move), #223 (per-node cap race), #213.

logan added the area/discord

labels 2026-10-05 02:05:06 -04:00

Sign in to join this conversation.