logan/server-26
1
0
Fork 0
Code Issues 84 Pull Requests Actions Packages Projects Releases Wiki Activity

Discord: no self-serve guild->org link and no admin UI for radio channels/bots (follow-up to #203/#204) #213

New Issue
Open
opened 2026-10-04 18:10:01 -04:00 by logan · 5 comments
logan commented 2026-10-04 18:10:01 -04:00
Owner
Copy Link
Copy Source

Follow-up left open by the feat/discord-system PR (server-26#203/#204, node-26#25).

What exists after that PR: discord_guilds/{guild_id}.org_id scopes every bot command; a platform admin can set it with PUT /discord/guilds/{id}/link. A guild with no link falls back to DISCORD_UNLINKED_GUILD_ORG_ID (default founding), which keeps today's single-org deployment working but means any server the DRB bot is invited to acts for the founding org until linked. Set it to "" once real links exist.

Not built (design-canvas/discord-system-notes.md Phase 1 items 1 and 6):

  1. /drb link code: in the Discord bot + web-side code generation (reuse the /auth/link pattern), so an org owner links their own server; unlinked servers see only /drb link and /help.
  2. Frontend admin page: linked guilds, streams (desired vs actual), radio bots with valid / guild membership / invite_url / lease. /tokens page still shows only the legacy in_use/assigned_node_id mirrors; the new token fields (valid, guild_ids, check_error, invite_url, lease) and POST /tokens/{id}/refresh have no UI.
  3. Node page "Join Discord" still takes raw guild/channel IDs (also #109 item 13); it now maps onto a stream pinned to that node.
  4. GET /tokens is now platform-admin only (#204 item 6) — the systems page preferred-token picker (app/systems/page.tsx ~L1227) will error for a non-admin.

Unverified: frontend has no typecheck on this box.

Follow-up left open by the feat/discord-system PR (server-26#203/#204, node-26#25). **What exists after that PR:** `discord_guilds/{guild_id}.org_id` scopes every bot command; a platform admin can set it with `PUT /discord/guilds/{id}/link`. A guild with no link falls back to `DISCORD_UNLINKED_GUILD_ORG_ID` (default `founding`), which keeps today's single-org deployment working but means **any** server the DRB bot is invited to acts for the founding org until linked. Set it to `""` once real links exist. **Not built (design-canvas/discord-system-notes.md Phase 1 items 1 and 6):** 1. `/drb link code:` in the Discord bot + web-side code generation (reuse the `/auth/link` pattern), so an org owner links their own server; unlinked servers see only `/drb link` and `/help`. 2. Frontend admin page: linked guilds, streams (desired vs actual), radio bots with `valid` / guild membership / `invite_url` / lease. `/tokens` page still shows only the legacy `in_use`/`assigned_node_id` mirrors; the new token fields (`valid`, `guild_ids`, `check_error`, `invite_url`, `lease`) and `POST /tokens/{id}/refresh` have no UI. 3. Node page "Join Discord" still takes raw guild/channel IDs (also #109 item 13); it now maps onto a stream pinned to that node. 4. `GET /tokens` is now platform-admin only (#204 item 6) — the systems page preferred-token picker (`app/systems/page.tsx` ~L1227) will error for a non-admin. Unverified: frontend has no typecheck on this box.
logan commented 2026-10-04 20:02:36 -04:00
Author
Owner
Copy Link
Copy Source

PR for item 1 (self-serve /drb link + web code generation + unlinked-server gate): #218 — branch feat/213-guild-link. Items 2-4 remain for the sibling slices.

PR for item 1 (self-serve /drb link + web code generation + unlinked-server gate): https://git.vpn.cusano.net/logan/server-26/pulls/218 — branch feat/213-guild-link. Items 2-4 remain for the sibling slices.
logan commented 2026-10-04 20:07:56 -04:00
Author
Owner
Copy Link
Copy Source

PR #219 (feat/213-discord-admin): item 4 fixed (systems-page preferred-token picker, /tokens and the /network Bot Tokens card are now admin-only; no non-admin listing endpoint, because the save behind the picker is admin-only too) and item 2 built (Settings > Discord: radio channels desired vs actual, servers + link, radio bots with valid / membership / invite links / lease / refresh; /tokens shows the same table). Items 1 and 3 are not in it. Unlink + org-owner view filed as #221.

PR #219 (`feat/213-discord-admin`): item 4 fixed (systems-page preferred-token picker, `/tokens` and the `/network` Bot Tokens card are now admin-only; no non-admin listing endpoint, because the save behind the picker is admin-only too) and item 2 built (Settings > Discord: radio channels desired vs actual, servers + link, radio bots with valid / membership / invite links / lease / refresh; `/tokens` shows the same table). Items 1 and 3 are not in it. Unlink + org-owner view filed as #221.
logan commented 2026-10-04 20:08:47 -04:00
Author
Owner
Copy Link
Copy Source

Item 3 is in PR #220 (feat/213-node-join-picker): #220

  • The raw-ID modal is replaced by a picker over the org's servers and the voice channels the DRB bot pushes (PUT /discord/guilds/{id}/directory). A pick becomes a stream pinned to the node through the #216 desired-state API.
  • Pairs with #218 (item 1): the picker reads #218's guild_name and skips fallback for servers with unlinked_at. The two PRs merge without conflicts.
  • Start/stop is now allowed for the org owner and the owning operator, not only platform admins.
  • The legacy raw-ID discord_join now refuses servers outside the node's org.
  • Prod needs the discord-bot image redeployed before any channels show up.

Items 2 and 4 are still open (other slices).

Item 3 is in PR #220 (`feat/213-node-join-picker`): https://git.vpn.cusano.net/logan/server-26/pulls/220 - The raw-ID modal is replaced by a picker over the org's servers and the voice channels the DRB bot pushes (`PUT /discord/guilds/{id}/directory`). A pick becomes a stream pinned to the node through the #216 desired-state API. - Pairs with #218 (item 1): the picker reads #218's `guild_name` and skips fallback for servers with `unlinked_at`. The two PRs merge without conflicts. - Start/stop is now allowed for the org owner and the owning operator, not only platform admins. - The legacy raw-ID `discord_join` now refuses servers outside the node's org. - Prod needs the discord-bot image redeployed before any channels show up. Items 2 and 4 are still open (other slices).
logan commented 2026-10-04 22:43:01 -04:00
Author
Owner
Copy Link
Copy Source

Follow-up PR #224 (feat/discord-stream-logging-remove): #224

  • c2-core now logs every node-reported radio-channel state transition with the node's error text and reason code, plus a line naming the token when a radio bot fails to log in.
  • Remove a radio channel: admin on Settings > Discord, org owner on the node page. It is stopped through desired state first, then deleted.
  • Remove a server: admin, Servers tab. It is unlinked with no fallback org, and the radio bots can optionally leave.

The live "bot online but never in voice" symptom is node-26#37.

Follow-up PR #224 (`feat/discord-stream-logging-remove`): https://git.vpn.cusano.net/logan/server-26/pulls/224 - c2-core now logs every node-reported radio-channel state transition with the node's error text and reason code, plus a line naming the token when a radio bot fails to log in. - Remove a radio channel: admin on Settings > Discord, org owner on the node page. It is stopped through desired state first, then deleted. - Remove a server: admin, Servers tab. It is unlinked with no fallback org, and the radio bots can optionally leave. The live "bot online but never in voice" symptom is node-26#37.
logan commented 2026-10-05 00:31:58 -04:00
Author
Owner
Copy Link
Copy Source

Owner-reported overwrite bug (adding a radio channel to a voice channel that already had one replaced it and kicked its bot) is fixed in PR #227: #227 (branch fix/213-multi-stream-per-channel). Per the owner decision, a voice channel can carry several streams, each with its own bot and system. Stream ids are now unique per stream; old guild:channel ids keep working. Picking a bot that is already in the server returns a 409 that names the stream using it. No Client change needed.

Owner-reported overwrite bug (adding a radio channel to a voice channel that already had one replaced it and kicked its bot) is fixed in PR #227: https://git.vpn.cusano.net/logan/server-26/pulls/227 (branch fix/213-multi-stream-per-channel). Per the owner decision, a voice channel can carry several streams, each with its own bot and system. Stream ids are now unique per stream; old guild:channel ids keep working. Picking a bot that is already in the server returns a 409 that names the stream using it. No Client change needed.
logan added the area/discordarea/frontend
priority
p2
type
feature
 labels 2026-10-05 02:05:03 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/ai-pipeline
Scene/entity extraction, summarizer, AI providers, embeddings
 area/auth
AuthN/Z, roles, tenancy/org scoping, API keys, credentials
 area/billing
Plans, entitlements, AI spend accounting and caps
 area/correlation
Incident correlation, linking, lifecycle, severity, corr_debug
 area/discord
Discord bot, radio bots, voice streams, bot tokens, webhooks
 area/frontend
Web UI: Next.js app and the edge-node local dashboard
 area/governance
Board process, minutes, unattended runner, agent tooling
 area/growth
Go-to-market, outreach, cold email, discovery conversations
 area/infra-deploy
CI/CD, VM, registry, Firestore rules/indexes deploy, Terraform/Caddy
 area/legal
ToS, retention, licences/DAAs, CAN-SPAM, E&O, name suppression
 area/map
Live map: pins, paths, tiles, legend, geocoding
 area/mqtt
Node-C2 MQTT, checkins, commands, node sweeper, dynsec
 area/node-ota
Node install, enrollment, OTA updater, image skew
 area/osint
External feeds: cameras, 511, ADS-B, AIS, outages, and their licences
 area/recording-audio
Call capture, boundaries, PulseAudio, ring buffer, trimming, attribution
 area/sdr-radio
OP25 decode, SDR hardware/tuning, conventional, second SDR, mesh radio
 area/transcription
STT, transcript correction, place verification, name accuracy
 board
Board process: minutes and board-filed items
 board:agenda
Needs board scoping at the next sitting; CEO removes the label once scoped
 minutes:draft
One exec pre-read, closed by CEO
 minutes:final
CEO ruling; open until enacted
 role:ceo
Filed by the CEO
 role:cfo
Filed by the CFO
 role:cio
Filed by the CIO
 role:ciso
Filed by the CISO
 role:cmo
Filed by the CMO
 role:coo
Filed by the COO
 role:cto
Filed by the CTO
kind
behavior-bug
Wrong product behavior; the instrument reads it correctly
kind
measurement-bug
Corrupts the recording/instrument (debug data, evals, health checks), not behavior
priority
p0
Drop everything: prod broken, live exposure, or owner-ruled P0
priority
p1
Next up: blocks a gate, a customer, or core incident quality
priority
p2
Normal: real defect or planned work, schedule in turn
priority
p3
Low: minor, cosmetic, or someday
status
blocked
Waiting on an external party, spend, or another issue
status
in-progress
Branch or PR open against it
status
needs-decision
Waiting on an owner or board ruling before work
status
needs-info
Root cause or repro unknown; needs a reading first
type
bug
Something built is wrong: code, data, or a measurement
type
chore
Maintenance, refactor, tests, pinning, cleanup: no user-visible change
type
decision
A ruling to make or record: board minutes, owner calls, legal reviews
type
docs
Docs, runbooks, CLAUDE.md, skills, SOPs
type
feature
New capability or an extension of an existing one
type
security
Security, privacy, credential or tenant-isolation exposure
type
tracking
Tracker, checklist, initiative or punch-list spanning several changes
No labels area/discord area/frontend
priority
p2
type
feature
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
logan
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: logan/server-26#213