ci: deploy Firestore rules + indexes on every push to main (#51) #124

2026-09-07T19:45:14-04:00

logan commented

2026-09-07 19:45:14 -04:00

Two commits:

1 — CI step. The deploy job SSHes to the VM (authed as the project service account) and git pulls but never touched Firestore, so firestore.rules and every composite index regressed silently. Adds firebase deploy --only firestore:rules,firestore:indexes right after git pull, from infra/firestore/ (firebase.json pins c2-server). ADC auth, additive for indexes (no --force), warn-not-fail. VM prereq: npm i -g firebase-tools once (host has no node yet — step skips with a warning if absent).

2 — Fix the index file itself. The //direction note ("declare everything ASCENDING, Firestore scans either direction") was wrong for these query shapes. useCalls / useIncidents / useAlerts and c2-core search_calls all orderBy(x, 'desc') and every one threw FAILED_PRECONDITION on the live DB until an explicit DESCENDING index existed:

calls (org_id ASC, started_at DESC) — Archive 503
alert_events (org_id ASC, triggered_at DESC) — /watch Triggered Alerts
alert_events (acknowledged ASC, org_id ASC, triggered_at DESC) — nav alert badge
incidents (org_id ASC, started_at DESC) — already live, now declared

All four were created on c2-server with gcloud on 2026-09-08 to unbreak prod; this file now matches, so a firebase deploy is a no-op rather than a destructive diff. The old drift note telling a deployer to answer YES to deleting calls/incidents (org_id, started_at DESC) as "duplicates" is removed — those are the working indexes.

Backend range-filter indexes (status/ended_at, system_id/*) stay ASCENDING — genuinely direction-agnostic (no orderBy).

Closes #51, addresses #33.

🤖 Generated with Claude Code

Two commits: **1 — CI step.** The `deploy` job SSHes to the VM (authed as the project service account) and `git pull`s but never touched Firestore, so `firestore.rules` and every composite index regressed silently. Adds `firebase deploy --only firestore:rules,firestore:indexes` right after `git pull`, from `infra/firestore/` (firebase.json pins `c2-server`). ADC auth, additive for indexes (no `--force`), warn-not-fail. **VM prereq:** `npm i -g firebase-tools` once (host has no node yet — step skips with a warning if absent). **2 — Fix the index file itself.** The `//direction` note ("declare everything ASCENDING, Firestore scans either direction") was **wrong** for these query shapes. `useCalls` / `useIncidents` / `useAlerts` and c2-core `search_calls` all `orderBy(x, 'desc')` and every one threw `FAILED_PRECONDITION` on the live DB until an explicit DESCENDING index existed: - `calls (org_id ASC, started_at DESC)` — Archive 503 - `alert_events (org_id ASC, triggered_at DESC)` — /watch Triggered Alerts - `alert_events (acknowledged ASC, org_id ASC, triggered_at DESC)` — nav alert badge - `incidents (org_id ASC, started_at DESC)` — already live, now declared All four were created on `c2-server` with `gcloud` on 2026-09-08 to unbreak prod; this file now matches, so a `firebase deploy` is a no-op rather than a destructive diff. The old drift note telling a deployer to answer YES to deleting `calls/incidents (org_id, started_at DESC)` as "duplicates" is removed — those are the working indexes. Backend range-filter indexes (`status/ended_at`, `system_id/*`) stay ASCENDING — genuinely direction-agnostic (no orderBy). Closes #51, addresses #33. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

logan added 1 commit 2026-09-07 19:45:15 -04:00

ci: deploy Firestore rules + indexes on every push to main (#51 ) 775244bbde

The deploy job SSHes to the VM (which runs as the project service account) but never touched Firestore, so rules and composite indexes regressed silently after every fix. Add a firebase-tools deploy right after `git pull`, additive for indexes, warn-not-fail on error.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Claude-Session: https://claude.ai/code/session_01Tbknwttzou4s46PAykmtix

logan added 1 commit 2026-09-07 23:20:52 -04:00

firestore: declare DESC indexes for the orderBy(desc) queries (#33/#51) bd04bdbd69

The old //direction note ('ASC serves orderBy desc') was wrong for these query shapes and left useCalls/useIncidents/useAlerts and search_calls throwing FAILED_PRECONDITION. Declare calls/incidents/alert_events (…, DESC) to match the live DB (indexes created via gcloud 2026-09-08). Drop the misleading 'delete these duplicates' drift note.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Claude-Session: https://claude.ai/code/session_01Tbknwttzou4s46PAykmtix

logan merged commit 7f4d684966 into main

2026-09-07 23:22:38 -04:00

logan deleted branch fix/51-ci-firestore-deploy

2026-09-07 23:22:42 -04:00

logan referenced this pull request

2026-09-07 23:49:09 -04:00

No automated deploy path for Firestore rules — they can regress silently after every fix #51

logan referenced this pull request

2026-09-07 23:49:09 -04:00

firestore.indexes.json has drifted from the live database and now duplicates two of its indexes #33

logan referenced this pull request

2026-09-13 17:38:39 -04:00